Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test case for IPAddressAllocation #907

Merged

Conversation

zhengxiexie
Copy link
Contributor

@zhengxiexie zhengxiexie commented Nov 19, 2024

--- PASS: TestIPAddressAllocation (44.85s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationExternal (13.70s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationPrivate (15.58s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationPrivateTGW (15.57s)

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.43%. Comparing base (a1693cd) to head (55b66aa).
Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   73.37%   73.43%   +0.05%     
==========================================
  Files         118      118              
  Lines       16394    16362      -32     
==========================================
- Hits        12029    12015      -14     
+ Misses       3581     3564      -17     
+ Partials      784      783       -1     
Flag Coverage Δ
unit-tests 73.43% <ø> (+0.05%) ⬆️

see 16 files with indirect coverage changes

@zhengxiexie
Copy link
Contributor Author

/e2e

10 similar comments
@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie
Copy link
Contributor Author

/e2e

@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/ipa_e2e branch from 88d10b4 to 14c4bc4 Compare December 19, 2024 06:54
@zhengxiexie zhengxiexie changed the title ipa e2e Add e2e test case for IPAddressAllocation Dec 19, 2024
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/ipa_e2e branch from 14c4bc4 to 84103b3 Compare December 19, 2024 07:08
@zhengxiexie
Copy link
Contributor Author

/e2e

1 similar comment
@zhengxiexie
Copy link
Contributor Author

/e2e

Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just some nits

test/e2e/nsx_ipaddressallocation_test.go Outdated Show resolved Hide resolved
test/e2e/nsx_ipaddressallocation_test.go Outdated Show resolved Hide resolved
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/ipa_e2e branch from 84103b3 to f19c109 Compare December 27, 2024 10:22
yanjunz97
yanjunz97 previously approved these changes Dec 30, 2024
@zhengxiexie zhengxiexie force-pushed the topic/zhengxie/main/ipa_e2e branch from f2a4a8a to 55b66aa Compare January 6, 2025 06:38
@zhengxiexie zhengxiexie merged commit 4cc0aee into vmware-tanzu:main Jan 6, 2025
2 checks passed
zhengxiexie added a commit that referenced this pull request Jan 7, 2025
…padd

[CP]Add e2e test case for IPAddressAllocation(#907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants