-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test case for IPAddressAllocation #907
Merged
zhengxiexie
merged 1 commit into
vmware-tanzu:main
from
zhengxiexie:topic/zhengxie/main/ipa_e2e
Jan 6, 2025
Merged
Add e2e test case for IPAddressAllocation #907
zhengxiexie
merged 1 commit into
vmware-tanzu:main
from
zhengxiexie:topic/zhengxie/main/ipa_e2e
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
November 20, 2024 10:49
b3cb1c8
to
88d10b4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
==========================================
+ Coverage 73.37% 73.43% +0.05%
==========================================
Files 118 118
Lines 16394 16362 -32
==========================================
- Hits 12029 12015 -14
+ Misses 3581 3564 -17
+ Partials 784 783 -1
|
/e2e |
10 similar comments
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
/e2e |
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
December 19, 2024 06:54
88d10b4
to
14c4bc4
Compare
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
December 19, 2024 07:08
14c4bc4
to
84103b3
Compare
/e2e |
1 similar comment
/e2e |
yanjunz97
reviewed
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just some nits
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
December 27, 2024 10:22
84103b3
to
f19c109
Compare
yanjunz97
previously approved these changes
Dec 30, 2024
dantingl
reviewed
Jan 6, 2025
test/e2e/manifest/testIPAddressAllocation/ipaddressallocation_privatetgw.yaml
Outdated
Show resolved
Hide resolved
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
January 6, 2025 06:16
f19c109
to
f2a4a8a
Compare
dantingl
reviewed
Jan 6, 2025
zhengxiexie
force-pushed
the
topic/zhengxie/main/ipa_e2e
branch
from
January 6, 2025 06:38
f2a4a8a
to
55b66aa
Compare
dantingl
reviewed
Jan 6, 2025
test/e2e/manifest/testIPAddressAllocation/ipaddressallocation_external.yaml
Show resolved
Hide resolved
dantingl
approved these changes
Jan 6, 2025
yanjunz97
approved these changes
Jan 6, 2025
zhengxiexie
added a commit
that referenced
this pull request
Jan 7, 2025
…padd [CP]Add e2e test case for IPAddressAllocation(#907)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--- PASS: TestIPAddressAllocation (44.85s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationExternal (13.70s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationPrivate (15.58s)
--- PASS: TestIPAddressAllocation/testIPAddressAllocationPrivateTGW (15.57s)